[3.15] gh-151483: Only declare PyCodeObject._co_unique_id on Free Threading (GH-151484)#152588
Closed
miss-islington wants to merge 1 commit into
Closed
[3.15] gh-151483: Only declare PyCodeObject._co_unique_id on Free Threading (GH-151484)#152588miss-islington wants to merge 1 commit into
PyCodeObject._co_unique_id on Free Threading (GH-151484)#152588miss-islington wants to merge 1 commit into
Conversation
…reading (pythonGH-151484) (cherry picked from commit 0cbac06) Co-authored-by: Xiaowei Lu <lxw263044@alibaba-inc.com>
Member
Ah yes, this PR changes the ABI, but I didn't recall if the ABI is already stable in Python 3.15 beta releases. I don't think that this change is worth it for the 3.15 branch (it's not worth it breaking the ABI), so I close the PR. |
Contributor
|
I was going to comment that this would break PyO3, for example. Thanks for closing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0cbac06)
Co-authored-by: Xiaowei Lu lxw263044@alibaba-inc.com
PyCodeObject._co_unique_idconditional onPy_GIL_DISABLED#151483